lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Fri, 18 Apr 2014 17:25:53 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Ryan Desfosses <ryan@...fo.org>, bhelgaas@...gle.com
CC:	trivial@...nel.org, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH 0/8] patch series

On 04/18/2014 05:16 PM, Ryan Desfosses wrote:
> There are eight patches in this series.  All changes are trivial with no
> dependencies or required order.
> --

My small comments:

a. The Subject should have mentioned PCI and trivial.

b. Please use imperative mood for patch descriptions.  I.e.,

use remove instead of removed;
use move instead of moved;
use merge instead of merged;
use add instead of added.


Don't resend the patches based only on my comments (unless the PCI
maintainer asks you to do so).


thanks,
-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ