linux-kernel - Re: [RFC PATCH 1/1] x86/apic: add apic_irqs bitmap to identify irqs from apic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 24 Apr 2014 09:22:55 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Jason Chen <jason.cj.chen@...el.com>
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 1/1] x86/apic: add apic_irqs bitmap to identify irqs
 from apic


* Jason Chen <jason.cj.chen@...el.com> wrote:

> The function irq_force_complete_move() might handle irqs based on
> the non-apic irq_chip the way apic does, which has the structure
> irq_cfg as its chip_data.
> Wrong operations on non-apic irq_chip might make its chip_data changed
> and bring unexpected issues.
> Add apic_irqs bitmap to identify irqs from apic, and filter out all other
> irq_chips by checking this bitmap.

Please update the changelog to describe the current behavior, and how 
it affects your platform. (I.e. how do users notice, if at all?)

Then describe why you think that behavior should be changed. ie: 
what's the reason for this patch.

Only then describe the details of the change itself.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/