linux-kernel - Re: [PATCH 1/1] uprobes/tracing: uprobe_perf_open() forgets to handle the error from uprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Apr 2014 14:33:41 +0530
From:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Steven Rostedt <rostedt@...dmis.org>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Anton Arapov <aarapov@...hat.com>,
	David Long <dave.long@...aro.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] uprobes/tracing: uprobe_perf_open() forgets to
 handle	the error from uprobe_apply()


Acked-by: Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
(with 2 nits that you can ignore)

>  		done = tu->filter.nr_systemwide ||
> -			event->parent || event->attr.enable_on_exec ||
> +			(event->hw.tp_target->flags & PF_EXITING) ||
>  			uprobe_filter_event(tu, event);
> -		list_add(&event->hw.tp_list, &tu->filter.perf_events);
>  	} else {
> +		tu->filter.nr_systemwide--;
>  		done = tu->filter.nr_systemwide;
> -		tu->filter.nr_systemwide++;
>  	}

Nit: I think 2 lines can be made into
 done = --tu->filter.nr_systemwide;


<snipped>
>  		done = tu->filter.nr_systemwide ||
> -			(event->hw.tp_target->flags & PF_EXITING) ||
> +			event->parent || event->attr.enable_on_exec ||
>  			uprobe_filter_event(tu, event);
> +		list_add(&event->hw.tp_list, &tu->filter.perf_events);
>  	} else {
> -		tu->filter.nr_systemwide--;
>  		done = tu->filter.nr_systemwide;
> +		tu->filter.nr_systemwide++;
>  	}

Nit: Similarly lines can be made into
 done = tu->filter.nr_systemwide++;


-- 
Thanks and Regards
Srikar Dronamraju

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/