linux-kernel - Re: [PATCH 1/5] iio: exynos_adc: use indio_dev->dev structure to handle child nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 26 Apr 2014 19:21:01 +0530
From:	Naveen Krishna Ch <naveenkrishna.ch@...il.com>
To:	Jonathan Cameron <jic23@...nel.org>
Cc:	Doug Anderson <dianders@...omium.org>,
	Naveen Krishna Chatradhi <ch.naveen@...sung.com>,
	linux-iio <linux-iio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	"cpgs ." <cpgs@...sung.com>, Grant Grundler <grundler@...omium.org>
Subject: Re: [PATCH 1/5] iio: exynos_adc: use indio_dev->dev structure to
 handle child nodes

Hello Jonathan,

On 26 April 2014 18:23, Jonathan Cameron <jic23@...nel.org> wrote:
> On 25/04/14 16:46, Doug Anderson wrote:
>>
>> Naveen,
>>
>> Thanks for sending this.  Given that Jonathan Cameron was involved in
>> the previous discussion, it probably would have been wise to include
>> him on the CC list.
>
> In my case, don't worry too much as I have linux-iio coming into exactly
> the same place in my inbox. Doug is correct that it is generally a good
> idea unless someone has asked you not to.
Sure, will make it a habit.
>
>>
>> On Fri, Apr 25, 2014 at 3:14 AM, Naveen Krishna Chatradhi
>> <ch.naveen@...sung.com> wrote:
>>>
>>> From: Naveen Krishna Ch <ch.naveen@...sung.com>
>>>
>>> Using pdev->dev with device_for_each_child() would iterate over all
>>> of the children of the platform device and delete them.
>>> Thus, causing crashes during module unload.
>>>
>>> We should be using the indio_dev->dev structure for
>>> registering/unregistering child nodes.
>>>
>>> Signed-off-by: Naveen Krishna Ch <ch.naveen@...sung.com>
>>> ---
>>> This change was tested on top of
>>>     https://lkml.org/lkml/2014/4/21/481 from Doug.
>>>
>>>   drivers/iio/adc/exynos_adc.c |    6 +++---
>>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>>
>> Reported-by: Doug Anderson <dianders@...omium.org>
>> Reviewed-by: Doug Anderson <dianders@...omium.org>
>> Tested-by: Doug Anderson <dianders@...omium.org>
>
> Applied to the fixes-togreg branch of iio.git
I've submitted the v2.
Kindly, review the other 4 patches in this series.
Thanks
>
> Thanks.
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>



-- 
Shine bright,
(: Nav :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/