linux-kernel - Re: [PATCH v2] tracing: Allow changing default ring buffer size for ftrace instances.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Apr 2014 18:19:29 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Bharath Ravi <rbharath@...gle.com>
Cc:	Vaibhav Nagarnaik <vnagarnaik@...gle.com>,
	David Sharp <dhsharp@...gle.com>,
	Laurent Chavey <chavey@...gle.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] tracing: Allow changing default ring buffer size for
 ftrace instances.

On Tue, 29 Apr 2014 15:09:15 -0700
Bharath Ravi <rbharath@...gle.com> wrote:

> We'd actually considered doing just that, in an initial version of the patch.
> At the time, we'd decided in favour of allowing the user more explicit
> control over the buffer size, rather than auto expanding it. (The
> discussion on that is here:
> https://lkml.org/lkml/2013/7/1/617)

Yeah, I remember my rational :-)

The thing is, I have been thinking more about it, and I'm now thinking
it would be fine. But reading that email again, I may have convinced
myself that it should have the option. Gah, I'm now arguing with myself!

> 
> We could go back to that though if you think that's okay, but I think
> your previous reasoning still makes sense: it's useful for the user to
> know if there will be an allocation failure before enabling tracing.

Grumble. I need to think about this a bit more. I'm stretching myself a
bit thin between different projects. I'll pull in you patches and play
with it a bit and then come back with a decision.

Thanks!

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/