linux-kernel - [PATCH 1/3] PM / OPP: Add support for descending order for cpufreq table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Apr 2014 15:28:34 +0900
From:	Jonghwan Choi <jhbird.choi@...sung.com>
To:	open list <linux-kernel@...r.kernel.org>
Cc:	"'Rafael J. Wysocki'" <rjw@...ysocki.net>,
	'Len Brown' <len.brown@...el.com>,
	'Amit Daniel Kachhap' <amit.daniel@...sung.com>
Subject: [PATCH 1/3] PM / OPP: Add support for descending order for cpufreq
 table

In the frequency table dts file, the frequencies are arranged in
descending order which maps 1 to 1 with other frequency parameter to
be calculated and programmed in some registers.
But the OPP library works by generating the frequencies in ascending
order which breaks the above logic.
So added OPP_TABLE_ORDER_DESCEND flag to consider descending order.

Cc: Amit Daniel Kachhap <amit.daniel@...sung.com>
Signed-off-by: Jonghwan Choi <jhbird.choi@...sung.com>
---
 drivers/base/power/opp.c |   17 ++++++++++++++++-
 include/linux/pm_opp.h   |    7 +++++--
 2 files changed, 21 insertions(+), 3 deletions(-)

diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c
index 2553867..ec7d553 100644
--- a/drivers/base/power/opp.c
+++ b/drivers/base/power/opp.c
@@ -18,6 +18,7 @@
 #include <linux/cpufreq.h>
 #include <linux/device.h>
 #include <linux/list.h>
+#include <linux/list_sort.h>
 #include <linux/rculist.h>
 #include <linux/rcupdate.h>
 #include <linux/pm_opp.h>
@@ -597,10 +598,21 @@ int dev_pm_opp_disable(struct device *dev, unsigned
long freq)
 EXPORT_SYMBOL_GPL(dev_pm_opp_disable);
 
 #ifdef CONFIG_CPU_FREQ
+
+static int opp_descend_cmp(void *priv, struct list_head *a,
+                                        struct list_head *b)
+{
+        struct dev_pm_opp *ra = list_entry(a, struct dev_pm_opp, node);
+        struct dev_pm_opp *rb = list_entry(b, struct dev_pm_opp, node);
+
+        return rb->rate - ra->rate;
+}
+
 /**
  * dev_pm_opp_init_cpufreq_table() - create a cpufreq table for a device
  * @dev:	device for which we do this operation
  * @table:	Cpufreq table returned back to caller
+ * @flags:	OPP_TABLE_ORDER_DESCEND or zero
  *
  * Generate a cpufreq table for a provided device- this assumes that the
  * opp list is already initialized and ready for usage.
@@ -622,7 +634,7 @@ EXPORT_SYMBOL_GPL(dev_pm_opp_disable);
  * or in contexts where mutex locking cannot be used.
  */
 int dev_pm_opp_init_cpufreq_table(struct device *dev,
-			    struct cpufreq_frequency_table **table)
+		struct cpufreq_frequency_table **table, unsigned char flags)
 {
 	struct device_opp *dev_opp;
 	struct dev_pm_opp *opp;
@@ -649,6 +661,9 @@ int dev_pm_opp_init_cpufreq_table(struct device *dev,
 		return -ENOMEM;
 	}
 
+	if (flags & OPP_TABLE_ORDER_DESCEND)
+		list_sort(NULL, &dev_opp->opp_list, opp_descend_cmp);
+
 	list_for_each_entry(opp, &dev_opp->opp_list, node) {
 		if (opp->available) {
 			freq_table[i].driver_data = i;
diff --git a/include/linux/pm_opp.h b/include/linux/pm_opp.h
index 5151b00..cf42770 100644
--- a/include/linux/pm_opp.h
+++ b/include/linux/pm_opp.h
@@ -118,13 +118,16 @@ static inline int of_init_opp_table(struct device
*dev)
 #endif
 
 #if defined(CONFIG_CPU_FREQ) && defined(CONFIG_PM_OPP)
+
+#define OPP_TABLE_ORDER_DESCEND                (1 << 1)
+
 int dev_pm_opp_init_cpufreq_table(struct device *dev,
-			    struct cpufreq_frequency_table **table);
+		struct cpufreq_frequency_table **table, unsigned char
flags);
 void dev_pm_opp_free_cpufreq_table(struct device *dev,
 				struct cpufreq_frequency_table **table);
 #else
 static inline int dev_pm_opp_init_cpufreq_table(struct device *dev,
-			    struct cpufreq_frequency_table **table)
+		struct cpufreq_frequency_table **table, unsigned char flags)
 {
 	return -EINVAL;
 }
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/