linux-kernel - Re: [PATCH v8 14/20] usb: phy: msm: Add support for secondary PHY control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 30 Apr 2014 11:22:28 -0500
From:	Felipe Balbi <balbi@...com>
To:	"Ivan T. Ivanov" <iivanov@...sol.com>
CC:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Randy Dunlap <rdunlap@...radead.org>,
	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	David Brown <davidb@...eaurora.org>,
	<linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-usb@...r.kernel.org>, Manu Gautam <mgautam@...eaurora.org>
Subject: Re: [PATCH v8 14/20] usb: phy: msm: Add support for secondary PHY
 control

Hi,

On Mon, Apr 28, 2014 at 04:34:17PM +0300, Ivan T. Ivanov wrote:
> From: "Ivan T. Ivanov" <iivanov@...sol.com>
> 
> Allow support to use 2nd HSPHY with USB2 Core.
> Some platforms may have configuration to allow USB controller
> work with any of the two HSPHYs present. By default driver
> configures USB core to use primary HSPHY. Add support to allow
> user select 2nd HSPHY using DT parameter.
> 
> Signed-off-by: Ivan T. Ivanov <iivanov@...sol.com>
> Cc: Manu Gautam <mgautam@...eaurora.org>
> ---
>  .../devicetree/bindings/usb/msm-hsusb.txt          |  6 ++++++
>  drivers/usb/phy/phy-msm-usb.c                      | 24 ++++++++++++++++++++--
>  include/linux/usb/msm_hsusb.h                      |  1 +
>  include/linux/usb/msm_hsusb_hw.h                   |  1 +
>  4 files changed, 30 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/msm-hsusb.txt b/Documentation/devicetree/bindings/usb/msm-hsusb.txt
> index ee4123d..0669667 100644
> --- a/Documentation/devicetree/bindings/usb/msm-hsusb.txt
> +++ b/Documentation/devicetree/bindings/usb/msm-hsusb.txt
> @@ -59,6 +59,12 @@ Optional properties:
>                  For example: qcom,phy-init-sequence = < -1 0x63 >;
>                  Will update only value at address ULPI_EXT_VENDOR_SPECIFIC + 1.
> 
> +- qcom,phy-num: Select number of pyco-phy to use, can be one of
> +                0 - PHY one, default
> +                1 - Second PHY
> +                Some platforms may have configuration to allow USB
> +                controller work with any of the two HSPHYs present.

I have a feeling there's a better to do this with of alias. But it would
be good if Kumar or any of the DT folks could pitch in.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)