linux-kernel - Re: [PATCH] fbdev/fb.h: silence warning with -Wsign-compare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 2 May 2014 15:59:37 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Brian W Hart <hartb@...ux.vnet.ibm.com>, <plagnioj@...osoft.com>,
	<linux-fbdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<trivial@...nel.org>
Subject: Re: [PATCH] fbdev/fb.h: silence warning with -Wsign-compare

On 01/05/14 22:32, Brian W Hart wrote:
> Silence the warning when building with -Wsign-compare when fb.h is
> included:
> 
> include/linux/fb.h: In function ‘__fb_pad_aligned_buffer’:
> include/linux/fb.h:650:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
>    for (j = 0; j < s_pitch; j++)
>                  ^
> 
> Signed-off-by: Brian W Hart <hartb@...ux.vnet.ibm.com>
> ---
> Compile tested only.
> 
>  include/linux/fb.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/fb.h b/include/linux/fb.h
> index fe6ac95..0da7634 100644
> --- a/include/linux/fb.h
> +++ b/include/linux/fb.h
> @@ -641,7 +641,7 @@ static inline void unlock_fb_info(struct fb_info *info)
>  static inline void __fb_pad_aligned_buffer(u8 *dst, u32 d_pitch,
>  					   u8 *src, u32 s_pitch, u32 height)
>  {
> -	int i, j;
> +	u32 i, j;
>  
>  	d_pitch -= s_pitch;
>  
> 

Thanks, queued for 3.16.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)