linux-kernel - Re: [PATCH] staging: rtl8821ae: mark pointer in pci_iounmap as _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 3 May 2014 20:26:17 -0400
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Martin Kepplinger <martink@...teo.de>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8821ae: mark pointer in pci_iounmap as
 __iomem

On Sat, May 03, 2014 at 05:10:48PM +0200, Martin Kepplinger wrote:
> pci_iounmap is used that way in drivers/net/wireless/rtlwifi and this
> fixes sparse warnings.
> 
> Signed-off-by: Martin Kepplinger <martink@...teo.de>
> ---
>  drivers/staging/rtl8821ae/pci.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8821ae/pci.c b/drivers/staging/rtl8821ae/pci.c
> index a562aa6..d934ecb 100644
> --- a/drivers/staging/rtl8821ae/pci.c
> +++ b/drivers/staging/rtl8821ae/pci.c
> @@ -2416,7 +2416,7 @@ fail3:
>  	ieee80211_free_hw(hw);
>  
>  	if (rtlpriv->io.pci_mem_start != 0)
> -		pci_iounmap(pdev, (void *)rtlpriv->io.pci_mem_start);
> +		pci_iounmap(pdev, (void __iomem *)rtlpriv->io.pci_mem_start);

Shouldn't pci_mem_start be a __iomem pointer instead?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/