[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 05 May 2014 14:44:39 +0200
From: Martin Kepplinger <martink@...teo.de>
To: Dan Carpenter <dan.carpenter@...cle.com>
CC: gregkh@...uxfoundation.org, driverdev-devel@...uxdriverproject.org,
linux-kernel@...r.kernel.org, lidza.louina@...il.com
Subject: Re: [RESEND PATCH] staging: dgnc: use dev_err() instead of printk()
Am 2014-05-05 14:36, schrieb Dan Carpenter:
> On Mon, May 05, 2014 at 01:59:25PM +0200, Martin Kepplinger wrote:
>> Am 2014-05-05 13:35, schrieb Dan Carpenter:
>>> On Mon, May 05, 2014 at 12:29:39PM +0200, Martin Kepplinger wrote:
>>>> Use dev_err() instead of printk() and remove "dgnc:" from the message.
>>>> This should provide userspace with more useful information and use
>>>> the common kernel coding style.
>>>>
>>>
>>> Whenever I see a "RESEND" in a subject and no explanation then it means
>>> our development process has broken down. Meanwhile this is the first
>>> time I have seen this patch so the problem is not on our side.
>>>
>>> regards,
>>> dan carpenter
>>>
>>
>> I just resent https://lkml.org/lkml/2014/4/29/164 after waiting a week
>> or so. I don't see any breakdown.
>
> What I'm saying is just put an explanation after the --- cut off so we
> know what you did wrong the first time.
>
> Signed-off-by ...
> ---
> Resending because I sent it to the wrong email list the first time.
> Oops! Next time I will use get_maintainer.pl, I promise!
>
>
> Just a simple explanation like that is ok.
>
> regards,
> dan carpenter
>
sure, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists