[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 05 May 2014 16:15:03 +0200
From: Tomasz Stanislawski <t.stanislaws@...sung.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org,
linux-doc@...r.kernel.org, t.figa@...sung.com,
kyungmin.park@...sung.com, m.szyprowski@...sung.com,
robh+dt@...nel.org, arnd@...db.de, grant.likely@...aro.org,
kgene.kim@...sung.com, rdunlap@...radead.org, ben-linux@...ff.org
Subject: Re: [PATCH 0/2] Add support for sii9234 chip
On 05/04/2014 01:17 AM, Greg KH wrote:
> On Fri, Apr 11, 2014 at 01:48:28PM +0200, Tomasz Stanislawski wrote:
>> Hi everyone,
>> This patchset adds support for sii9234 HD Mobile Link Bridge. The chip is used
>> to convert HDMI signal into MHL. The driver enables HDMI output on Trats and
>> Trats2 boards.
>>
>> The code is based on the driver [1] developed by:
>> Adam Hampson <ahampson@....samsung.com>
>> Erik Gilling <konkers@...roid.com>
>> with additional contributions from:
>> Shankar Bandal <shankar.b@...sung.com>
>> Dharam Kumar <dharam.kr@...sung.com>
>>
>> The drivers architecture was greatly simplified and transformed into a form
>> accepted (hopefully) by opensource community. The main differences from
>> original code are:
>> * using single I2C client instead of 4 subclients
>> * remove all logic non-related to establishing HDMI link
>> * simplify error handling
>> * rewrite state machine in interrupt handler
>> * wakeup and discovery triggered by an extcon event
>> * integrate with Device Tree
>>
>> For now, the driver is added to drivers/misc/ directory because it has neigher
>> userspace nor kernel interface. The chip is capable of receiving and
>> processing CEC events, so the driver may export an input device in /dev/ in the
>> future. However CEC could be also handled by HDMI driver.
>>
>> I kindly ask for suggestions about the best location for this driver.
>
> It really is an extcon driver, so why not put it in drivers/extcon? And
> that might solve any build issues you have if you don't select extcon in
> your .config file and try to build this code :)
>
> thanks,
Hi Greg,
Thank you for your comments.
As I understand, drivers/extcon contains only extcon providers.
This driver is an extcon client, so mentioned location may not be adequate.
I am surprised that there are no comments about this driver.
Sii9234 chip is present on many exynos based boards/phones
and HDMI subsystem will not work without this code.
Regards,
Tomasz Stanislawski
>
> greg k-h
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists