linux-kernel - rtc: add support for maxim dallas rtc ds1343 and ds1344

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 05 May 2014 23:46:06 +0530
From:	RAGHAVENDRA GANIGA <ravi23ganiga@...il.com>
To:	a.zummo@...ertech.it, rtc-linux@...glegroups.com
CC:	linux-kernel@...r.kernel.org
Subject: rtc: add support for maxim dallas rtc ds1343 and ds1344

> On Wed, 30 Apr 2014 21:55:07 +0530
> Raghavendra Ganiga <ravi23ganiga@...il.com> wrote:
>> +static int ds1343_proc(struct device *dev, struct seq_file *seq)
>> +{
>> +     struct ds1343_priv *priv = dev_get_drvdata(dev);
>> +     unsigned int data;
>> +     unsigned char alarm_mode = 0;
>> +     const char *alarm_str, *diodes = "disabled", *resistors = " ";
>> +
>> +     regmap_read(priv->map, DS1343_CONTROL_REG, &data);
>  is this thing really useful? what about having sysfs entries
>  instead?



i am replacing the proc interface with the sysfs entries
also removing the unnecessary parameters. i am adding the
following parameters as sysfs entries

1. glitch filter read and write parameter
2. alarm status read parameter
3. alarm mode read parameter
4. trickle charger read parameter

and i am removing the proc interface. 

is the above implementation ok as per your last comment
on the proc interface. please provide the feedback.

Thanks and regards
Raghavendra Chandra Ganiga

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/