linux-kernel - Re: [RFC PATCH] ftrace function-graph: print the function name on all } lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 5 May 2014 15:38:38 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	"Elliott, Robert (Server Storage)" <Elliott@...com>
Cc:	"fweisbec@...il.com" <fweisbec@...il.com>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"linux-kernel (linux-kernel@...r.kernel.org)" 
	<linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] ftrace function-graph: print the function name on
 all } lines

On Mon, 5 May 2014 19:21:03 +0000
"Elliott, Robert (Server Storage)" <Elliott@...com> wrote:

> > From: Steven Rostedt [mailto:rostedt@...dmis.org]
> > ...
> > Yes it is too cluttered. Please make this a tracing option that is
> > default off.
> 
> The TRACE_GRAPH_PRINT_xx macros exist in two places:
> * trace.h has one set
> * trace_functions_graph.c has redefinitions of them and adds 
>   TRACE_GRAPH_PRINT_IRQS.  
> 
> The new macro will only be used inside trace_functions_graph.c. 
> That is true of some of the others like TRACE_GRAPH_PRINT_OVERRUN, 
> so doesn't seem to be the guiding principle for separate sets.
> 
> Should the new one be added to both places, or should the 
> duplicate definitions in trace_functions_graph.c be removed?
> 
> trace_functions_graph.c:
> #include "trace.h"
> ...
> /* Flag options */
> #define TRACE_GRAPH_PRINT_OVERRUN       0x1
> #define TRACE_GRAPH_PRINT_CPU           0x2
> #define TRACE_GRAPH_PRINT_OVERHEAD      0x4
> #define TRACE_GRAPH_PRINT_PROC          0x8
> #define TRACE_GRAPH_PRINT_DURATION      0x10
> #define TRACE_GRAPH_PRINT_ABS_TIME      0x20
> #define TRACE_GRAPH_PRINT_IRQS          0x40
> #define TRACE_GRAPH_PRINT_TAIL          0x80 /* <-- new */
> 
> trace.h:
> /* Flag options */
> #define TRACE_GRAPH_PRINT_OVERRUN       0x1
> #define TRACE_GRAPH_PRINT_CPU           0x2
> #define TRACE_GRAPH_PRINT_OVERHEAD      0x4
> #define TRACE_GRAPH_PRINT_PROC          0x8
> #define TRACE_GRAPH_PRINT_DURATION      0x10
> #define TRACE_GRAPH_PRINT_ABS_TIME      0x20
> #define TRACE_GRAPH_PRINT_FILL_SHIFT    28
> #define TRACE_GRAPH_PRINT_FILL_MASK     (0x3 << TRACE_GRAPH_PRINT_FILL_SHIFT)

This is a bit sloppy. Looks like some of them were copied over to
trace.h to be used in other files, but never deleted from their
original location :-/

Probably should just move them all to trace.h. I want to change this
code in the near future anyway.

-- Steve

> 
> ---
> Rob Elliott    HP Server Storage

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/