linux-kernel - Re: [PATCH] staging: android: fix missing a blank line after declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 05 May 2014 12:51:08 -0700
From:	Joe Perches <joe@...ches.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>, devel@...verdev.osuosl.org,
	Seunghun Lee <waydi1@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: android: fix missing a blank line after
 declarations

On Mon, 2014-05-05 at 12:59 +0300, Dan Carpenter wrote:
> On Sat, May 03, 2014 at 07:43:26PM -0400, Greg KH wrote:
> > On Tue, Apr 29, 2014 at 08:32:21PM +0300, Dan Carpenter wrote:
> > > On Wed, Apr 30, 2014 at 01:59:12AM +0900, Seunghun Lee wrote:
> > > > This patch fixes "Missing a blank line after declarations" warnings.
> > > > 
> > > > Signed-off-by: Seunghun Lee <waydi1@...il.com>
> > > 
> > > Quite a few of these are false checkpatch.pl false positives.  Just
> > > ignore the false positives.
> > 
> > Really?  It looks good to me, what am I missing?
> > 
> 
> Gar.  You're right.  In my head I remember seeing a bunch of false
> positives but now that I'm looking at it again I'm not sure what I was
> talking about.

I think they were around here:

> diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
[]
> @@ -228,8 +230,10 @@ struct binder_node {
>  	int internal_strong_refs;
>  	int local_weak_refs;
>  	int local_strong_refs;
> +
>  	binder_uintptr_t ptr;
>  	binder_uintptr_t cookie;
> +
>  	unsigned has_strong_ref:1;

These 2 new blank lines aren't necessary.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/