linux-kernel - Re: [PATCH 5/8] usb: phy: msm: reset controller is mandatory now

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 08 May 2014 17:58:44 +0300
From:	"Ivan T. Ivanov" <iivanov@...sol.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Felipe Balbi <balbi@...com>
Subject: Re: [PATCH 5/8] usb: phy: msm: reset controller is mandatory now

On Thu, 2014-05-08 at 16:27 +0200, Arnd Bergmann wrote:
> On Thursday 08 May 2014 17:21:49 Ivan T. Ivanov wrote:
> > > @@ -168,7 +168,7 @@ config USB_EHCI_HCD_AT91
> > >  
> > >  config USB_EHCI_MSM
> > >       tristate "Support for Qualcomm QSD/MSM on-chip EHCI USB controller"
> > > -     depends on ARCH_MSM
> > > +     depends on ARCH_MSM && RESET_CONTROLLER
> > 
> > This driver did not use reset controller API.
> > 
> > >       select USB_EHCI_ROOT_HUB_TT
> > >       select USB_MSM_OTG
> 
> It does select USB_MSM_OTG though, which uses it:
> 
> Maybe that 'select' is wrong?

Driver have run time dependency to USB_PHY framework.
Probably just removing  select line will be fine?

Regards,
Ivan



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/