linux-kernel - Re: [regression 3.15-rc3] Resume from s4 broken by 1f81b6d22a5980955b01e08cf27fb745dc9b686f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 09 May 2014 11:07:40 +0300
From:	Mathias Nyman <mathias.nyman@...ux.intel.com>
To:	Ville Syrjälä <ville.syrjala@...ux.intel.com>
CC:	Julius Werner <jwerner@...omium.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [regression 3.15-rc3] Resume from s4 broken by 1f81b6d22a5980955b01e08cf27fb745dc9b686f


>> I can't see how this relates to Julius patch though, and I'm not sure yet why it
>> only triggers when devices are connected to SS ports. Maybe just unlucky timing?
>
> I think the non-SS ports are connected to the EHCI controllers rather
> than the XHCI controllers. So that explains at least one detail. And I
> guess timing is as good an excuse as any why this gets exposed by the
> patch in question.

That's right, sometimes I forget that there exists something else than xHCI.

>
>>
>> Does this help?:
>
> Indeed it does. The machine just survived a dozen or so suspend+resume
> cycles without a hitch. The bug was 100% reproducible on this machine,
> so the fix seems solid.
>
> Tested-by: Ville Syrjälä <ville.syrjala@...ux.intel.com>
>

Great, a patch with your Tested-by tag pushed to my tree at:

git://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git for-usb-linus

-Mathias


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/