linux-kernel - Re: [PATCH] i2c: qup: Fix pm_runtime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 9 May 2014 09:51:59 -0700
From:	Bjorn Andersson <bjorn@...o.se>
To:	Andy Gross <agross@...eaurora.org>,
	Wolfram Sang <wsa@...-dreams.de>
Cc:	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	Bjorn Andersson <bjorn.andersson@...ymobile.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	linux-arm-msm <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH] i2c: qup: Fix pm_runtime_get_sync usage

On Fri, May 2, 2014 at 6:54 PM, Andy Gross <agross@...eaurora.org> wrote:
[...]
> @@ -479,7 +479,7 @@ static int qup_i2c_xfer(struct i2c_adapter *adap,
>         int ret, idx;
>
>         ret = pm_runtime_get_sync(qup->dev);
> -       if (ret)
> +       if (ret < 0)
>                 goto out;

Sorry about that, thought I tested that path properly.
Wolfram, please pick this up as soon as possible as it renders the
driver useless if one enables pm runtime.

Acked-by: Bjorn Andersson <bjorn.andersson@...ymobile.com>

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/