linux-kernel - Re: [PATCH 1/1] kernel/time/ntp.c: convert simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 9 May 2014 11:17:56 -0700
From:	John Stultz <john.stultz@...aro.org>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/1] kernel/time/ntp.c: convert simple_strtol to kstrtol

On Fri, May 9, 2014 at 11:14 AM, Fabian Frederick <fabf@...net.be> wrote:
>

Commit message missing.  Mind adding a brief description of why this
change is worth making?

> Inspired-By: Andrew Morton <akpm@...ux-foundation.org>
> Cc: John Stultz <john.stultz@...aro.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  kernel/time/ntp.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/time/ntp.c b/kernel/time/ntp.c
> index 419a52c..82b7c9e 100644
> --- a/kernel/time/ntp.c
> +++ b/kernel/time/ntp.c
> @@ -923,7 +923,10 @@ void __hardpps(const struct timespec *phase_ts, const struct timespec *raw_ts)
>
>  static int __init ntp_tick_adj_setup(char *str)
>  {
> -       ntp_tick_adj = simple_strtol(str, NULL, 0);
> +       int rc = kstrtol(str, 0, (long *)&ntp_tick_adj);
> +
> +       if (rc)
> +               return rc;
>         ntp_tick_adj <<= NTP_SCALE_SHIFT;
>
>         return 1;
> --
> 1.8.4.5
>

thanks
-john
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/