linux-kernel - Re: [PATCH 1/1 RESEND] drivers/scsi/sd.c: remove positive test on unsigned value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 10 May 2014 15:04:50 +0000
From:	James Bottomley <jbottomley@...allels.com>
To:	"fabf@...net.be" <fabf@...net.be>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/1 RESEND] drivers/scsi/sd.c: remove positive test on
 unsigned value

On Sat, 2014-05-10 at 12:49 +0200, Fabian Frederick wrote:
> val is unsigned.

Please send to linux-scsi@...r.kernel.org ... this is one of Martin's I
think.

James

> Cc: "James E.J. Bottomley" <JBottomley@...allels.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  drivers/scsi/sd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> index efcbcd1..b54d4f8 100644
> --- a/drivers/scsi/sd.c
> +++ b/drivers/scsi/sd.c
> @@ -296,7 +296,7 @@ protection_type_store(struct device *dev, struct device_attribute *attr,
>  	if (err)
>  		return err;
>  
> -	if (val >= 0 && val <= SD_DIF_TYPE3_PROTECTION)
> +	if (val <= SD_DIF_TYPE3_PROTECTION)
>  		sdkp->protection_type = val;
>  
>  	return count;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/