linux-kernel - Re: [patch 24/32] sh: intc: Remove pointless irq_reserve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 11 May 2014 09:53:13 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Peter Anvin <hpa@...or.com>, Tony Luck <tony.luck@...el.com>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [patch 24/32] sh: intc: Remove pointless irq_reserve_irqs()
 invocation

On Wed, May 07, 2014 at 03:44:18PM -0000, Thomas Gleixner wrote:
> The preceding call to irq_create_identity_mapping() marks the
> interrupt as allocated already. Remove the leftover.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: linux-sh@...r.kernel.org
> Cc: Simon Horman <horms@...ge.net.au>

This duplicates a similar patch, "[PATCH v3 2/8] sh, irq: Remove
irq_reserve_irq calling", by Yinghai Lu. But perhaps you already know that.

Regardless, I am fine with the contents.

Acked-by: Simon Horman <horms+renesas@...ge.net.au>

> ---
>  drivers/sh/intc/core.c |    6 ------
>  1 file changed, 6 deletions(-)
> 
> Index: tip/drivers/sh/intc/core.c
> ===================================================================
> --- tip.orig/drivers/sh/intc/core.c
> +++ tip/drivers/sh/intc/core.c
> @@ -80,12 +80,6 @@ static void __init intc_register_irq(str
>  	unsigned int data[2], primary;
>  	unsigned long flags;
>  
> -	/*
> -	 * Register the IRQ position with the global IRQ map, then insert
> -	 * it in to the radix tree.
> -	 */
> -	irq_reserve_irq(irq);
> -
>  	raw_spin_lock_irqsave(&intc_big_lock, flags);
>  	radix_tree_insert(&d->tree, enum_id, intc_irq_xlate_get(irq));
>  	raw_spin_unlock_irqrestore(&intc_big_lock, flags);
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/