lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 May 2014 23:35:42 -0400 From: Sasha Levin <sasha.levin@...cle.com> To: linux-mm@...ck.org Cc: kirill.shutemov@...ux.intel.com, davej@...hat.com, linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk, peterz@...radead.org, mingo@...nel.org, Sasha Levin <sasha.levin@...cle.com> Subject: [PATCH] mm: remap_file_pages: grab file ref to prevent race while mmaping A file reference should be held while a file is mmaped, otherwise it might be freed while being used. Suggested-by: Hugh Dickins <hughd@...gle.com> Signed-off-by: Sasha Levin <sasha.levin@...cle.com> --- mm/mmap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/mmap.c b/mm/mmap.c index 2a0e0a8..da3c212 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -2593,6 +2593,7 @@ SYSCALL_DEFINE5(remap_file_pages, unsigned long, start, unsigned long, size, struct vm_area_struct *vma; unsigned long populate = 0; unsigned long ret = -EINVAL; + struct file *file; pr_warn_once("%s (%d) uses deprecated remap_file_pages() syscall. " "See Documentation/vm/remap_file_pages.txt.\n", @@ -2636,8 +2637,10 @@ SYSCALL_DEFINE5(remap_file_pages, unsigned long, start, unsigned long, size, munlock_vma_pages_range(vma, start, start + size); } + file = get_file(vma->vm_file); ret = do_mmap_pgoff(vma->vm_file, start, size, prot, flags, pgoff, &populate); + fput(file); out: up_write(&mm->mmap_sem); if (populate) -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists