linux-kernel - Re: [rfc]pwm: add xilinx pwm driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 May 2014 09:23:59 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Bart Tanghe <bart.tanghe@...masmore.be>
Cc:	thierry.reding@...il.com, michal.simek@...inx.com,
	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	rob@...dley.net, grant.likely@...aro.org,
	linux-pwm@...r.kernel.org, devicetree@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [rfc]pwm: add xilinx pwm driver

On Wednesday 14 May 2014 13:26:13 Bart Tanghe wrote:
> @@ -0,0 +1,20 @@
> +Xilinx PWM controller
> +
> +Required properties:
> +- compatible: should be "xlnx,pwm-xlnx"
> +- add a clock source to the description
> +
> +Examples:
> +
> +               axi_timer_0: timer@...00000 {
> +                       clock-frequency = <100000000>;
> +                       clocks = <&clkc 15>;
> +                       compatible = "xlnx,xlnx-pwm";
> +                       reg = <0x42800000 0x10000>;
> +                       xlnx,count-width = <0x20>;
> +                       xlnx,gen0-assert = <0x1>;
> +                       xlnx,gen1-assert = <0x1>;
> +                       xlnx,one-timer-only = <0x0>;
> +                       xlnx,trig0-assert = <0x1>;
> +                       xlnx,trig1-assert = <0x1>;
> +               } ;
> 

It seems you are missing a mandatory "#pwm-cells" property.
How is anybody supposed to use this?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/