linux-kernel - Re: [PATCH v2 1/3] lib/crc7: Shift crc7() output left 1 bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	14 May 2014 22:02:38 -0400
From:	"George Spelvin" <linux@...izon.com>
To:	hpa@...or.com, linux@...izon.com, pavel@....cz
Cc:	arik@...ery.com, david.gnedt@...izone.at, eliad@...ery.com,
	jan.nikitenko@...il.com, laurent.pinchart+renesas@...asonboard.com,
	linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org,
	linux-spi@...r.kernel.org, linux-wireless@...r.kernel.org,
	linville@...driver.com, luca@...lho.fi, tony@...mide.com
Subject: Re: [PATCH v2 1/3] lib/crc7: Shift crc7() output left 1 bit

H. Peter Anvin wrote:
> Seems to me to make the code easier to read, not harder. That was the
> whole point.

I thought it made it harder by moving the terminating 1 bit out of the
driver proper, where it has a symbolic name.  Thus someone comparing
the driver to the spec has to read another source file to figure out
how the driver gets that bit set.

As it is, the straight-line code in the driver corresponds very simply
with the packet as illustrated in the data sheets.

I agree it's really really minor either way, but so is the saving
we're going for.

Since it's not *clearly* an improvement, I err on the side of not
messing with a driver I can't test.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/