linux-kernel - Re: [PATCH 1/1] fs/hfsplus/wrapper.c: replace min/casting by min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 15 May 2014 11:52:58 -0700
From:	Joe Perches <joe@...ches.com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Vyacheslav Dubeyko <slava@...eyko.com>,
	akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/1] fs/hfsplus/wrapper.c: replace min/casting by min_t

On Thu, 2014-05-15 at 19:05 +0200, Fabian Frederick wrote:
> Also add * before function comments (it was not detected by
> kernel-doc)
[]
> diff --git a/fs/hfsplus/wrapper.c b/fs/hfsplus/wrapper.c
[]
> @@ -234,7 +234,7 @@ reread:
>  	sbi->alloc_blksz_shift = 0;
>  	while ((blocksize >>= 1) != 0)
>  		sbi->alloc_blksz_shift++;

Unrelated, but perhaps this while loop
should use fls instead.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/