linux-kernel - Re: [PATCH 4/4] staging/wlan-ng: replace printk() with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 May 2014 14:57:39 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Denis Pithon <denis.pithon@...il.com>
Cc:	devel@...verdev.osuosl.org, himangi774@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] staging/wlan-ng: replace printk() with pr_xxx()

On Mon, May 12, 2014 at 05:22:47PM +0200, Denis Pithon wrote:
> Fix some coding style issues concerning printk() usage.
> 
> Signed-off-by: Denis Pithon <denis.pithon@...il.com>
> ---
>  drivers/staging/wlan-ng/p80211netdev.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c
> index 61a3092..3577d20 100644
> --- a/drivers/staging/wlan-ng/p80211netdev.c
> +++ b/drivers/staging/wlan-ng/p80211netdev.c
> @@ -384,8 +384,9 @@ static int p80211knetdev_hard_start_xmit(struct sk_buff *skb,
>  		 */
>  		if (skb->protocol != ETH_P_80211_RAW) {
>  			netif_start_queue(wlandev->netdev);
> -			printk(KERN_NOTICE
> -			       "Tx attempt prior to association, frame dropped.\n");
> +			pr_notice(
> +			   "Tx attempt prior to association, frame dropped\n"
> +			);

Can't these be netdev messages, or at the least, dev_* messages?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/