linux-kernel - Re: [PATCH 3/8] list: Out of line INIT_LIST_HEAD and list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 May 2014 20:03:11 -0400
From:	Dave Jones <davej@...hat.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 3/8] list: Out of line INIT_LIST_HEAD and list_del

On Fri, May 16, 2014 at 02:43:10PM -0700, Andi Kleen wrote:

 > diff --git a/lib/Makefile b/lib/Makefile
 > index 0cd7b68..8b744f7 100644
 > --- a/lib/Makefile
 > +++ b/lib/Makefile
 > @@ -13,7 +13,7 @@ lib-y := ctype.o string.o vsprintf.o cmdline.o \
 >  	 sha1.o md5.o irq_regs.o reciprocal_div.o argv_split.o \
 >  	 proportions.o flex_proportions.o prio_heap.o ratelimit.o show_mem.o \
 >  	 is_single_threaded.o plist.o decompress.o kobject_uevent.o \
 > -	 earlycpio.o
 > +	 earlycpio.o list.o

Hey Andi,

Did you test this with CONFIG_DEBUG_LIST ?
Unless I'm missing something, this looks like we'll have duplicate
symbols for list_del if that is set.

	Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/