linux-kernel - Re: [PATCH 05/28] staging: rtl8188eu: Remove unused function rtl8188eu_ps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 May 2014 13:52:08 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	navin patidar <navin.patidar@...il.com>
Cc:	gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/28] staging: rtl8188eu: Remove unused function
 rtl8188eu_ps_func()

On Sun, May 18, 2014 at 08:48:58PM +0530, navin patidar wrote:
> Signed-off-by: navin patidar <navin.patidar@...il.com>
> ---
>  drivers/staging/rtl8188eu/hal/usb_halinit.c |    8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> index 1a83d31..4c3f8c8 100644
> --- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> @@ -2231,12 +2231,6 @@ static void rtl8188eu_init_default_value(struct adapter *adapt)
>  		haldata->odmpriv.RFCalibrateInfo.ThermalValue_HP[i] = 0;
>  }
>  
> -static u8 rtl8188eu_ps_func(struct adapter *Adapter, enum hal_intf_ps_func efunc_id, u8 *val)
> -{
> -	u8 bResult = true;
> -	return bResult;
> -}
> -
>  void rtl8188eu_set_hal_ops(struct adapter *adapt)
>  {
>  	struct hal_ops	*halfunc = &adapt->HalFunc;
> @@ -2277,7 +2271,5 @@ void rtl8188eu_set_hal_ops(struct adapter *adapt)
>  	halfunc->hal_xmit = &rtl8188eu_hal_xmit;
>  	halfunc->mgnt_xmit = &rtl8188eu_mgnt_xmit;
>  
> -	halfunc->interface_ps_func = &rtl8188eu_ps_func;

No, this is used.  See rtw_hal_intf_ps_func().

drivers/staging/rtl8188eu/hal/hal_intf.c
   210  u8 rtw_hal_intf_ps_func(struct adapter *adapt,
   211                          enum hal_intf_ps_func efunc_id, u8 *val)
   212  {
   213          if (adapt->HalFunc.interface_ps_func)
   214                  return adapt->HalFunc.interface_ps_func(adapt, efunc_id,
   215                                                             val);
   216          return _FAIL;
   217  }

You have changed it to return _FAIL instead of true.  Perhaps that is ok
but you need to explain it in the changelog.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/