linux-kernel - Re: [RFC PATCH] of/irq: do irq resolution in platform_get_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 May 2014 14:57:39 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Grygorii Strashko <grygorii.strashko@...com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Rob Herring <robh+dt@...nel.org>,
	Grant Likely <grant.likely@...aro.org>,
	santosh.shilimkar@...com, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Russell King <linux@....linux.org.uk>,
	Rob Herring <robh@...nel.org>, Tony Lindgren <tony@...mide.com>
Subject: Re: [RFC PATCH] of/irq: do irq resolution in
 platform_get_irq_byname()

On Mon, May 19, 2014 at 04:30:59PM +0300, Grygorii Strashko wrote:
[...]
> diff --git a/drivers/of/irq.c b/drivers/of/irq.c
[...]
>  /**
> + * of_irq_get_byname - Decode a node's IRQ and return it as a Linux irq number
> + * @dev: pointer to device tree node
> + * @name: zero-based index of the irq

This is a name, not an index.

> + *
> + * Returns Linux irq number on success, or -EPROBE_DEFER if the irq domain
> + * is not yet created, or errorno in case of failure.

s/errorno/error code/? Also EPROBE_DEFER is also an error code, so I'm
not sure if it's worth a special case in the description here.

> + *
> + */
> +int of_irq_get_byname(struct device_node *dev, const char *name)
> +{
> +	const char *name_irq = NULL;
> +	int index = 0;
> +
> +	if (unlikely(!name))
> +		return -EINVAL;
> +
> +	while (!of_property_read_string_index(dev, "interrupt-names",
> +					      index, &name_irq))
> +		if (!strcmp(name, name_irq))
> +			return of_irq_get(dev, index);

Isn't this missing an index++ somewhere? Otherwise it seems like this
would loop infinitely if there was no match on the first entry.

Thierry

Content of type "application/pgp-signature" skipped