linux-kernel - Re: [PATCH 2/5] usb: gadget: net2280: Use S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 May 2014 21:35:59 +0200
From:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	"balbi@...com" <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux USB Mailing List <linux-usb@...r.kernel.org>,
	Joe Perches <joe@...ches.com>,
	Amit Uttamchandani <auttamchandani@...icube.com>
Subject: Re: [PATCH 2/5] usb: gadget: net2280: Use S_I macros

Hello Alan

What about using octal notation in all the file and merge the patch
with the other big patch of the series? I am trying to have some
consistency in the file :)


Thanks!

On Mon, May 19, 2014 at 9:30 PM, Alan Stern <stern@...land.harvard.edu> wrote:
> On Mon, 19 May 2014, Ricardo Ribalda Delgado wrote:
>
>> Instead of octal notation, to be consistent around the file.
>>
>> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
>> ---
>>  drivers/usb/gadget/net2280.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c
>> index c3205ec..5b2ab68 100644
>> --- a/drivers/usb/gadget/net2280.c
>> +++ b/drivers/usb/gadget/net2280.c
>> @@ -111,7 +111,7 @@ module_param(use_msi, bool, S_IRUGO);
>>  static ushort fifo_mode = 0;
>>
>>  /* "modprobe net2280 fifo_mode=1" etc */
>> -module_param (fifo_mode, ushort, 0644);
>> +module_param(fifo_mode, ushort, S_IRUGO | S_IWUSR);
>
> I don't think this is necessary, in and of itself.  In my opinion, the
> macros are a lot harder to figure out than the octal values.
>
> Don't bother making this change.  It's useless churn.
>
> Alan Stern
>



-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/