linux-kernel - Re: [PATCH v2 4/4] ARM: dts: bcm590xx: add support for GPLDO and VBUS regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 21 May 2014 14:30:38 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Matt Porter <mporter@...aro.org>
Cc:	Devicetree List <devicetree@...r.kernel.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Tim Kryger <tim.kryger@...aro.org>,
	Markus Mayer <markus.mayer@...aro.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux ARM Kernel List <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 4/4] ARM: dts: bcm590xx: add support for GPLDO and
 VBUS regulators

> > > diff --git a/arch/arm/boot/dts/bcm59056.dtsi b/arch/arm/boot/dts/bcm59056.dtsi
> > > index dfadaaa..066adfb 100644
> > > --- a/arch/arm/boot/dts/bcm59056.dtsi
> > > +++ b/arch/arm/boot/dts/bcm59056.dtsi
> > > @@ -70,5 +70,26 @@
> > >  
> > >  		vsr_reg: vsr {
> > >  		};
> > > +
> > > +		gpldo1_reg: gpldo1 {
> > > +		};
> > 
> > What do these empty nodes do in any case?
> 
> They instantiate regulators. The bcm590xx binding specifies the
> allowable subnode names permitted here. This replaces the old method
> of specifying an index or the deprecated regulator-compatible property.
> The board-specific dts includes this dtsi and applies any board
> constraints to a subset of regulators that need them. Unused regulators
> are all disabled which is what we want.
> 
> > Don't you at least need a status property in there or something?
> 
> Not necessary for these subnodes.

Very well, thanks for the clarification.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/