linux-kernel - Re: [PATCHv5 09/10] DTS: ARM: OMAP3-N900: Add SSI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 May 2014 02:05:58 +0200
From:	Sebastian Reichel <sre@...nel.org>
To:	Tony Lindgren <tony@...mide.com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Shubhrajyoti Datta <omaplinuxkernel@...il.com>,
	Carlos Chinea <cch.devel@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Kumar Gala <galak@...eaurora.org>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
	Pali Rohár <pali.rohar@...il.com>,
	Ивайло Димитров 
	<freemangordon@....bg>,
	Joni Lapilainen <joni.lapilainen@...il.com>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	Pavel Machek <pavel@....cz>, Paul Walmsley <paul@...an.com>
Subject: Re: [PATCHv5 09/10] DTS: ARM: OMAP3-N900: Add SSI support

Hi,

On Wed, May 21, 2014 at 03:08:07PM -0700, Tony Lindgren wrote:
> * Sebastian Reichel <sre@...nel.org> [140521 14:51]:
> > On Wed, May 21, 2014 at 12:45:28PM -0700, Tony Lindgren wrote:
> > 
> > Right. The only documentation of the SSI module is existing
> > code sent by Carlos / included in the maemo kernel.
> 
> That's probably better than any documentation though :)

Both have their advantages. Just with the code its hard to add
features like context loss checks.

> > > > It's probably something with the sysc or idlemodes that
> > > > keeps things from idling. Maybe wrong address? Or wrong
> > > > flags? I'm pretty sure it was the first .dts patch out of
> > > > these two as the second one alone did not apply.
> > > 
> > > Hmm yeah below is probably how it should be, does this
> > > work for you? With this fix applied and your ssi dts
> > > patches n900 keeps hitting off-idle for me.
> > 
> > I can confirm, that the N900 hits idle states when the DT
> > patch and the hwmod patch is applied. I have not actually
> > tested if it also works without your hwmod patch.
> > 
> > There are still problems with the idle state if the driver is
> > actually loaded (and I see 100% runtime pm usage in powertop),
> > but that can be fixed later.
> > 
> > Feel free to add Tested-by/Acked-By to the hwmod patch.
> 
> OK thanks for testing.

You are welcome.

> I'll apply your dts changes as soon as I have an ack from Paul on
> the hwmod changes. Probably best to queue them together to avoid
> PM breaking.

Ok. Sounds legit.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)