linux-kernel - Re: [PATCH v1] drivers/clocksource: do not trace read_sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 23 May 2014 08:51:11 +0800
From:	"Yang,Wei" <Wei.Yang@...driver.com>
To:	Daniel Lezcano <daniel.lezcano@...aro.org>
CC:	<tglx@...utronix.de>, <rostedt@...dmis.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] drivers/clocksource: do not trace read_sched_clock

On 05/22/2014 08:03 PM, Daniel Lezcano wrote:
> On 05/22/2014 03:50 AM, Yang,Wei wrote:
>> Hi Daniel,
>>
>> What do you think of it?
>>
>> Regards
>> Wei
>> On 05/13/2014 11:10 AM, Wei.Yang@...driver.com wrote:
>>> From: Yang Wei <Wei.Yang@...driver.com>
>>>
>>> We do not need to trace read_sched_clock function,
>>> so add notrace attribute for this function.
>
> Hi Yang,
>
> I agree with your patch. Applied in my tree for 3.16
>
> Please in the future fix the subject name:
>
> clocksource: [driver]: [A-Z]....

Daniel, Got it. I would be careful next time:-)

Thanks
Wei
>
> Thanks
>   -- Daniel
>
>>> Signed-off-by: Yang Wei <Wei.Yang@...driver.com>
>>> ---
>>>   drivers/clocksource/dw_apb_timer_of.c |    2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/clocksource/dw_apb_timer_of.c
>>> b/drivers/clocksource/dw_apb_timer_of.c
>>> index 2a2ea27..d305fb0 100644
>>> --- a/drivers/clocksource/dw_apb_timer_of.c
>>> +++ b/drivers/clocksource/dw_apb_timer_of.c
>>> @@ -106,7 +106,7 @@ static void __init add_clocksource(struct
>>> device_node *source_timer)
>>>       sched_rate = rate;
>>>   }
>>> -static u64 read_sched_clock(void)
>>> +static u64 notrace read_sched_clock(void)
>>>   {
>>>       return ~__raw_readl(sched_io_base);
>>>   }
>>
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/