linux-kernel - [PATCH 2/3] driver core/platform: make .name of struct platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 26 May 2014 18:41:22 +0200
From:	Emil Goode <emilgoode@...il.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	Yann Droneaud <ydroneaud@...eya.com>,
	Shawn Guo <shawn.guo@...escale.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Sascha Hauer <kernel@...gutronix.de>,
	Russell King <linux@....linux.org.uk>,
	Olof Johansson <olof@...om.net>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org, Emil Goode <emilgoode@...il.com>
Subject: [PATCH 2/3] driver core/platform: make .name of struct platform_object a C99 flexible array

From: Yann Droneaud <ydroneaud@...eya.com>

The changes made by this patch was originally part of the patch available
in the below link. It was requested that the change to .name was made in
a separate patch.

http://lkml.kernel.org/r/1390817152-30898-1-git-send-email-ydroneaud@opteya.com

It's a pity that 7 bytes are wasted at the end of struct platform_object
in the form of padding after name field: unfortunately this padding is not
used when allocating the memory to hold the name.

By making .name of struct platform_object a C99 flexible array member
(eg. a zero sized array), padding at the end of the structure is removed
making the storage for .dma_mask almost for free.

To handle this change, memory allocation is updated to take care of
allocating an additional byte for the NUL terminating character.

Built on Debian jessie, using GCC 4.8, for ARM and x86_64 architectures,
the size of the object file and the data structure layout are updated
as follows, produced with commands:

$ size drivers/base/platform.o
$ pahole drivers/base/platform.o \
	--recursive		 \
	--class_name device,pdev_archdata,platform_device,platform_object

-- size+pahole_3.15-rc6_ARM
++ size+pahole_3.15-rc6_ARM+
@@ -2,7 +2,7 @@
    text	   data	    bss	    dec	    hex	filename
-   6482	   1008	      8	   7498	   1d4a	drivers/base/platform.o
+   6486	   1008	      8	   7502	   1d4e	drivers/base/platform.o

@@ -91,15 +91,10 @@ struct platform_object {
 	/* XXX last struct has 4 bytes of padding */

 	/* --- cacheline 12 boundary (768 bytes) was 40 bytes ago --- */
-	char                       name[1];             /*   808     1 */
+	u64                        dma_mask;            /*   808     8 */
+	char                       name[0];             /*   816     0 */

-	/* XXX 7 bytes hole, try to pack */

-	u64                        dma_mask;            /*   816     8 */

-	/* size: 824, cachelines: 13, members: 3 */
-	/* sum members: 817, holes: 1, sum holes: 7 */
+	/* size: 816, cachelines: 13, members: 3 */
 	/* paddings: 1, sum paddings: 4 */
-	/* last cacheline: 56 bytes */
+	/* last cacheline: 48 bytes */
 };

(Note that on x86 the size command didn't show any difference)

-- size+pahole_3.15-rc6_x86_64
++ size+pahole_3.15-rc6_x86_64+
@@ -93,13 +93,10 @@ struct platform_device {
 struct platform_object {
 	struct platform_device     pdev;                /*     0  1440 */
 	/* --- cacheline 22 boundary (1408 bytes) was 32 bytes ago --- */
-	char                       name[1];             /*  1440     1 */
+	u64                        dma_mask;            /*  1440     8 */
+	char                       name[0];             /*  1448     0 */

-	/* XXX 7 bytes hole, try to pack */

-	u64                        dma_mask;            /*  1448     8 */

-	/* size: 1456, cachelines: 23, members: 3 */
-	/* sum members: 1449, holes: 1, sum holes: 7 */
-	/* last cacheline: 48 bytes */
+	/* size: 1448, cachelines: 23, members: 3 */
+	/* last cacheline: 40 bytes */
 };

Cc: Yann Droneaud <ydroneaud@...eya.com>
Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Signed-off-by: Yann Droneaud <ydroneaud@...eya.com>
[Emil: split the original patch, updated changelog and
 generated new data structure layout info]
Signed-off-by: Emil Goode <emilgoode@...il.com>
---
 drivers/base/platform.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index dd1fa07..ba98219 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -165,8 +165,8 @@ EXPORT_SYMBOL_GPL(platform_add_devices);
 
 struct platform_object {
 	struct platform_device pdev;
-	char name[1];
 	u64 dma_mask;
+	char name[];
 };
 
 /**
@@ -210,7 +210,7 @@ struct platform_device *platform_device_alloc(const char *name, int id)
 {
 	struct platform_object *pa;
 
-	pa = kzalloc(sizeof(struct platform_object) + strlen(name), GFP_KERNEL);
+	pa = kzalloc(sizeof(*pa) + strlen(name) + 1, GFP_KERNEL);
 	if (pa) {
 		strcpy(pa->name, name);
 		pa->pdev.name = pa->name;
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/