linux-kernel - Re: [PATCH] scsi: pm8001: pm8001_hwi.c: Fix for possible null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 May 2014 13:38:14 +0200
From:	Tomas Henzl <thenzl@...hat.com>
To:	Christoph Hellwig <hch@...radead.org>,
	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
CC:	xjtuwjp@...il.com, lindar_liu@...sh.com,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: pm8001: pm8001_hwi.c:  Fix for possible null pointer
 dereference

On 05/28/2014 01:28 PM, Christoph Hellwig wrote:
> On Sun, May 18, 2014 at 06:14:00PM +0200, Rickard Strandqvist wrote:
>> There is otherwise a risk of a possible null pointer dereference.
>>
>> Was largely found by using a static code analysis program called cppcheck.
> I can't see how dev->lldd_dev would be NULL here.

The analysis program likely can't know that, the reason for this report 
it that dev->lldd_dev is tested for not being null several lines below -
http://lxr.free-electrons.com/source/drivers/scsi/pm8001/pm8001_hwi.c#L4447
So the other option is to remove this^ test.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/