linux-kernel - [PATCH] SH: annotate code after BUG() as unreachable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 28 May 2014 15:57:32 -0700
From:	Brian Norris <computersforpeace@...il.com>
To:	Linux Kernel <linux-kernel@...r.kernel.org>
Cc:	Brian Norris <computersforpeace@...il.com>,
	linux-sh@...r.kernel.org
Subject: [PATCH] SH: annotate code after BUG() as unreachable

This squashes some warnings:

  CC      mm/bootmem.o
mm/bootmem.c: In function 'mark_bootmem':
mm/bootmem.c:379:1: warning: control reaches end of non-void function [-Wreturn-type]

  CC      kernel/sched/core.o
kernel/sched/core.c: In function 'pick_next_task':
kernel/sched/core.c:2610:1: warning: control reaches end of non-void function [-Wreturn-type]

Signed-off-by: Brian Norris <computersforpeace@...il.com>
Cc: linux-sh@...r.kernel.org
---
 arch/sh/include/asm/bug.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/sh/include/asm/bug.h b/arch/sh/include/asm/bug.h
index dcf278075429..1ae948f309f2 100644
--- a/arch/sh/include/asm/bug.h
+++ b/arch/sh/include/asm/bug.h
@@ -48,6 +48,7 @@ do {							\
 		   "i" (__FILE__),			\
 		   "i" (__LINE__), "i" (0),		\
 		   "i" (sizeof(struct bug_entry)));	\
+	unreachable();					\
 } while (0)
 
 #define __WARN_TAINT(taint)				\
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/