linux-kernel - Re: [PATCH] delete unnecessary bootmem struct page array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 1 Jun 2014 08:12:45 +0800
From:	Real Name <enjoymindful@...il.com>
To:	user-mode-linux-devel@...ts.sourceforge.net
Cc:	richard@....at, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] delete unnecessary bootmem struct page array

On Sun, Jun 01, 2014 at 07:34:42AM +0800, Real Name wrote:

I'm very sorry. Please ignore this email, the wrong patch had been sent
out.

> 1) uml kernel bootmem managed through bootmem_data->node_bootmem_map,
> not struct page array, so it is unnecessary.
> 
> 2) the struct page array allocate has been pointer by a *loacl* pointer
> struct page *map in init_maps function. The array can't be access after
> the init_maps exit. As a result, there is about 1% of total memory leak.
> ---
>  arch/um/kernel/um_arch.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c
> index 016adf0..9f3c6d1 100644
> --- a/arch/um/kernel/um_arch.c
> +++ b/arch/um/kernel/um_arch.c
> @@ -309,11 +309,6 @@ int __init linux_main(int argc, char **argv)
>  	 */
>  
>  	diff = UML_ROUND_UP(brk_start) - UML_ROUND_UP(&_end);
> -	if (diff > 1024 * 1024) {
> -		printf("Adding %ld bytes to physical memory to account for "
> -		       "exec-shield gap\n", diff);
> -		physmem_size += UML_ROUND_UP(brk_start) - UML_ROUND_UP(&_end);
> -	}
>  
>  	uml_physmem = (unsigned long) &__binary_start & PAGE_MASK;
>  
> -- 
> 1.8.3.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/