linux-kernel - Re: [PATCH RFC 1/2] MAINTAINERS: Add "R:" designated-reviewers tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Jun 2014 13:29:05 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Joe Perches <joe@...ches.com>
Cc:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org, mingo@...nel.org,
	laijs@...fujitsu.com, dipankar@...ibm.com,
	akpm@...ux-foundation.org, mathieu.desnoyers@...icios.com,
	josh@...htriplett.org, niv@...ibm.com, tglx@...utronix.de,
	peterz@...radead.org, dhowells@...hat.com, edumazet@...gle.com,
	dvhart@...ux.intel.com, fweisbec@...il.com, oleg@...hat.com,
	sbw@....edu
Subject: Re: [PATCH RFC 1/2] MAINTAINERS: Add "R:" designated-reviewers tag

On Mon, 02 Jun 2014 10:22:58 -0700
Joe Perches <joe@...ches.com> wrote:

> > Paul Walmsley also noted the need for patch
> > submitters to know who the key reviewers are and suggested adding an
> > "R:" tag to the MAINTAINERS file to record this information on a
> > per-subsystem basis.
> 
> I'm not sure of the value of this.
> 
> Why not just mark the actual reviewers as maintainers?
> 
> The lack of reviewers problem is entirely distinct from
> the proposed solution.
> 
> I believe active reviewers will generally subscribe to a
> subsystem specific mailing list.
> 
> Perhaps it'd be better to get a "linux-rcu@...r.kernel.org"
> mailing list going.

I don't think we need a linux-rcu mailing list. I much rather see the
patches on LKML.

If you have a person that regularly reviews a patch and wants to be
Cc'd on all of them, then why not add them to MAINTAINERS?

> 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> []
> > @@ -73,6 +73,8 @@ Descriptions of section entries:
> >  	L: Mailing list that is relevant to this area
> >  	W: Web-page with status/info
> >  	Q: Patchwork web based patch tracking system site
> > +	R: Designated reviewer, who should be CCed on patches,
> > +	   format: FullName <address@...ain>
> >  	T: SCM tree type and location.
> >  	   Type is one of: git, hg, quilt, stgit, topgit
> >  	S: Status, one of the following:
> 
> If this is actually done, I suggest putting this
> "R" entry description immediately after the "M" entry.
> 

Or perhaps after L:

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/