linux-kernel - Re: [PATCH] gpu: drm: msm: Replace type of paddr to uint32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 Jun 2014 10:50:00 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Rob Clark <robdclark@...il.com>, linux-arm-msm@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"Matwey V. Kornilov" <matwey@....msu.ru>,
	Bryan Huntsman <bryanh@...eaurora.org>,
	matwey.kornilov@...il.com, Daniel Walker <dwalker@...o99.com>,
	David Brown <davidb@...eaurora.org>
Subject: Re: [PATCH] gpu: drm: msm: Replace type of paddr to uint32_t.

On Thu, Jun 05, 2014 at 09:24:02AM +0200, Geert Uytterhoeven wrote:
> On Thu, Jun 5, 2014 at 2:05 AM, Rob Clark <robdclark@...il.com> wrote:
> > On Wed, Jun 4, 2014 at 6:54 AM, Matwey V. Kornilov <matwey@....msu.ru> wrote:
> >> From e7147352639fd8f92b1cc85cff9bc5046c7a2130 Mon Sep 17 00:00:00 2001
> >> From: "Matwey V. Kornilov" <matwey.kornilov@...il.com>
> >> Date: Mon, 2 Jun 2014 20:17:29 +0400
> >> Subject: [PATCH] Replace type of paddr to uint32_t.
> >>
> >> This patch helps to avoid the following build issue:
> >>
> >> drivers/gpu/drm/msm/msm_fbdev.c:108:2: error: passing argument 3 of
> >> 'msm_gem_get_iova_locked' from incompatible pointer type [-Werror]
> >>   msm_gem_get_iova_locked(fbdev->bo, 0, &paddr);
> >>   ^
> >> In file included from drivers/gpu/drm/msm/msm_fbdev.c:18:0:
> >> drivers/gpu/drm/msm/msm_drv.h:153:5: note: expected 'uint32_t *' but
> >> argument is of type 'dma_addr_t *'
> >>  int msm_gem_get_iova_locked(struct drm_gem_object *obj, int id,
> >>      ^
> >>
> >> Signed-off-by: Matwey V. Kornilov <matwey@....msu.ru>
> >
> > Reviewed-by: Rob Clark <robdclark@...il.com>
> 
> Perhaps the uint32_t should become dma_addr_t instead?
> 
> drivers/gpu/drm/msm/msm_gem.h has:
> 
>         struct {
>                 // XXX
>                 uint32_t iova;
>         } domain[NUM_DOMAINS];
> 
> (note the "XXX").

I agree, dma_addr_t is the proper type for I/O virtual addresses.

Thierry

Content of type "application/pgp-signature" skipped