linux-kernel - [PATCH] drivers/staging/speakup/main: fixed jiffie comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 13 Jun 2014 01:21:05 +0200
From:	Robin Schroer <sulamiification@...il.com>
To:	w.d.hubbs@...il.com
Cc:	gregkh@...uxfoundation.org, speakup@...ille.uwo.ca,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Robin Schroer <sulamiification@...il.com>
Subject: [PATCH] drivers/staging/speakup/main: fixed jiffie comparison

speakup_key() used manual comparison of jiffies to determine the time
since the last keypress, replaced it with time_after()

Resend with kernel mailing list cc'ed (duh...)

Signed-off-by: Robin Schroer <sulamiification@...il.com>
---
 drivers/staging/speakup/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
index 7de79d5..0cd3cdb 100644
--- a/drivers/staging/speakup/main.c
+++ b/drivers/staging/speakup/main.c
@@ -2067,7 +2067,7 @@ speakup_key(struct vc_data *vc, int shift_state, int keycode, u_short keysym,
 			if (up_flag)
 				goto out;
 			if (last_keycode == keycode &&
-			    last_spk_jiffy + MAX_DELAY > jiffies) {
+			    time_after(last_spk_jiffy + MAX_DELAY, jiffies)) {
 				spk_close_press = 1;
 				offset = spk_shift_table[shift_info + 32];
 				/* double press? */
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/