linux-kernel - Re: PATCH[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 11 Jun 2014 20:53:19 -0700
From:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:	Nick Krause <nickkrause@...patico.ca>
Cc:	"martyn.welch@...com" <martyn.welch@...com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"manohar.vanga@...il.com" <manohar.vanga@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: PATCH[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]

On Thu, Jun 12, 2014 at 03:44:34AM +0000, Nick Krause wrote:
> Hey Fellow Developers, 
> This is my first patch so if there are any errors please reply as i will 
> fix them. Below is the patch.
> -- drivers/vme/bridges/vme_ca91cx42.h.orig    2014-06-11 22:50:29.339671939 -0400
> +++ drivers/vme/bridges/vme_ca91cx42.h    2014-06-11 23:15:36.027685173 -0400
> @@ -526,7 +526,7 @@ static const int CA91CX42_LINT_LM[] = {
>  #define CA91CX42_VSI_CTL_SUPER_SUPR    (1<<21)
>  
>  #define CA91CX42_VSI_CTL_VAS_M        (7<<16)
> -#define CA91CX42_VSI_CTL_VAS_A16    0
> +#define CA91CX42_VSI_CTL_VAS_A16    (3<<16)
>  #define CA91CX42_VSI_CTL_VAS_A24    (1<<16)
>  #define CA91CX42_VSI_CTL_VAS_A32    (1<<17)
>  #define CA91CX42_VSI_CTL_VAS_USER1    (3<<17)
> @@ -549,7 +549,7 @@ static const int CA91CX42_LINT_LM[] = {
>  #define CA91CX42_LM_CTL_SUPR        (1<<21)
>  #define CA91CX42_LM_CTL_NPRIV        (1<<20)
>  #define CA91CX42_LM_CTL_AS_M        (5<<16)
> -#define CA91CX42_LM_CTL_AS_A16        0
> +#define CA91CX42_LM_CTL_AS_A16        (3<<16)
>  #define CA91CX42_LM_CTL_AS_A24        (1<<16)
>  #define CA91CX42_LM_CTL_AS_A32        (1<<17)
> Signed-off-by: Nicholas Krause <nickkrause@...patico.ca>

Always run your patch through scripts/checkpatch.pl first to catch the
issues that are 'obvious'.

After that, the signed-off-by: needs to be up in the changelog area,
there needs to be a changelog explaining why this patch is needed, and
the tabs need to be put back in the patch (your email client ate them.)

Can you try again?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/