| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 13 Jun 2014 16:55:35 -0400 From: Benjamin Tissoires <benjamin.tissoires@...hat.com> To: Dmitry Torokhov <dmitry.torokhov@...il.com> Cc: Ping Cheng <pinglinux@...il.com>, Jason Gerecke <killertofu@...il.com>, linux-input@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] Input - wacom: remove phys field in struct wacom On Jun 13 2014 or thereabouts, Benjamin Tissoires wrote: > On Jun 13 2014 or thereabouts, Dmitry Torokhov wrote: > > On Fri, Jun 13, 2014 at 04:29:04PM -0400, Benjamin Tissoires wrote: > > > This field is not used, remove it. > > > > We must have lost the assignment, but it should be assigned to phys of > > corresponding input device. > > hehe. Even in 2007, when the files moved under drivers/input/tablet, > there is no mention of assigning input_dev->phys :) > > I can send a patch to fix the other way around if you prefer (add > input_dev->phys). > Actually, I found the culprit: $ git describe c5b7c7c395a34f12cdf246d66c1feeff2933d584 v2.6.14-21-gc5b7c7c ---> Thu Sep 15 02:01:47 2005 I should have wait one more year to fix it :) No one complain about it for nearly 10 years, so I am not sure it will help assigning the ->phys field of input_dev. It's your call, Dmitry. Cheers, Benjamin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists