linux-kernel - [PATCH] staging: ced1401: userspace: use1401.c: Cleaning up if statement that always evaluates to true

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 15 Jun 2014 00:56:31 +0200
From:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Monam Agarwal <monamagarwal123@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: [PATCH] staging: ced1401: userspace: use1401.c:  Cleaning up if statement that always evaluates to true 

This if statement that always evaluates to true.
Unsigned variable can't be negative so it is unnecessary to test it.
This can of course also mean that there is a problem with this error test is 0 bytes an error?

This was found using a static code analysis program called cppcheck.

Rickard Strandqvist (1):
  staging: ced1401: userspace: use1401.c:  Cleaning up if statement that always evaluates to true

 drivers/staging/ced1401/userspace/use1401.c |    9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/