linux-kernel - Re: netconsole breaks netpoll on bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Jun 2014 12:12:06 -0700
From:	Cong Wang <cwang@...pensource.com>
To:	Stefan Priebe - Profihost AG <s.priebe@...fihost.ag>
Cc:	Stephen Hemminger <stephen@...workplumber.org>,
	David Miller <davem@...emloft.net>,
	"bridge@...ts.linux-foundation.org" 
	<bridge@...ts.linux-foundation.org>,
	Linux Netdev List <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: netconsole breaks netpoll on bridge

On Mon, Jun 16, 2014 at 12:05 PM, Stefan Priebe - Profihost AG
<s.priebe@...fihost.ag> wrote:
>
>> Am 16.06.2014 um 20:51 schrieb Cong Wang <cwang@...pensource.com>:
>>
>> On Mon, Jun 16, 2014 at 11:41 AM, Stefan Priebe - Profihost AG
>> <s.priebe@...fihost.ag> wrote:
>>>
>>>> Am 16.06.2014 um 20:05 schrieb Cong Wang <cwang@...pensource.com>:
>>>>
>>>> On Mon, Jun 16, 2014 at 5:51 AM, Stefan Priebe - Profihost AG
>>>> <s.priebe@...fihost.ag> wrote:
>>>>> Hi,
>>>>>
>>>>> i'm using a vanilla 3.10.43 kernel and netconsole on top of a bridge.
>>>>>
>>>>> netconsole is used with vmbr0 (bridge) which is on top of bond0.
>>>>>
>>>>> If i want to add another bridge to vmbr0 is fails as long as netconsole
>>>>> is in use.
>>>>>
>>>>> # brctl addif vmbr0 fwpr2004p0
>>>>> can't add fwpr2004p0 to bridge vmbr0: Unknown error 524
>>>>>
>>>>> Kernel output:
>>>>> netpoll: (null): fwpr2004p0 doesn't support polling, aborting
>>>>>
>>>>> If i do rmmod netconsole - everything is working fine again.
>>>>
>>>> This is expected, you can't add an interface which doesn't support
>>>> netpoll to a bridge which is running netpoll.
>>>
>>> Thanks, so i can't use netconsole at a bridge used for vms?
>>
>> You can, but you need to make sure all the devices under
>> this bridge support netpoll. Not considering mac learning,
>> bridge just broadcasts all the packets to its ports, if one of them
>> doesn't support netpoll, how could it work?
>
> Ok i was trying to add a veth device so this is the problematic device.
>

We can just add netpoll support to veth device, it should not be hard.
I will work on it once net-next is open.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/