linux-kernel - [PATCH] drivers/base: redundant return value settings in try_to_bring_up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Jun 2014 16:25:31 +0800
From:	Liu Ying <Ying.Liu@...escale.com>
To:	<linux-kernel@...r.kernel.org>
CC:	<rmk+kernel@....linux.org.uk>, <gregkh@...uxfoundation.org>
Subject: [PATCH] drivers/base: redundant return value settings in try_to_bring_up_master()

Remove redundant return value settings 'ret = 0;' in the function
try_to_bring_up_master(), since it has already been set to zero.

Signed-off-by: Liu Ying <Ying.Liu@...escale.com>
---
 drivers/base/component.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/base/component.c b/drivers/base/component.c
index c477899..007600e 100644
--- a/drivers/base/component.c
+++ b/drivers/base/component.c
@@ -123,13 +123,11 @@ static int try_to_bring_up_master(struct master *master,
 		if (master->ops->add_components(master->dev, master)) {
 			/* Failed to find all components */
 			master_remove_components(master);
-			ret = 0;
 			goto out;
 		}
 
 		if (component && component->master != master) {
 			master_remove_components(master);
-			ret = 0;
 			goto out;
 		}
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/