| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Jun 2014 18:08:43 -0600 From: Bjorn Helgaas <bhelgaas@...gle.com> To: Murali Karicheri <m-karicheri2@...com> Cc: linux-arm <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, Santosh Shilimkar <santosh.shilimkar@...com>, Russell King <linux@....linux.org.uk>, Grant Likely <grant.likely@...aro.org>, Rob Herring <robh+dt@...nel.org>, Mohit Kumar <mohit.kumar@...com>, Jingoo Han <jg1.han@...sung.com>, Pratyush Anand <pratyush.anand@...com>, Richard Zhu <r65037@...escale.com>, Kishon Vijay Abraham I <kishon@...com>, Marek Vasut <marex@...x.de>, Arnd Bergmann <arnd@...db.de>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Randy Dunlap <rdunlap@...radead.org> Subject: Re: [PATCH v2 0/8] Add Keystone PCIe controller driver On Tue, Jun 10, 2014 at 02:51:19PM -0400, Murali Karicheri wrote: > This patch adds a PCIe controller driver for Keystone SoCs. This > is based on v1 of the series posted to the mailing list. > > CC: Santosh Shilimkar <santosh.shilimkar@...com> > CC: Russell King <linux@....linux.org.uk> > CC: Grant Likely <grant.likely@...aro.org> > CC: Rob Herring <robh+dt@...nel.org> > CC: Mohit Kumar <mohit.kumar@...com> > CC: Jingoo Han <jg1.han@...sung.com> > CC: Bjorn Helgaas <bhelgaas@...gle.com> > CC: Pratyush Anand <pratyush.anand@...com> > CC: Richard Zhu <r65037@...escale.com> > CC: Kishon Vijay Abraham I <kishon@...com> > CC: Marek Vasut <marex@...x.de> > CC: Arnd Bergmann <arnd@...db.de> > CC: Pawel Moll <pawel.moll@....com> > CC: Mark Rutland <mark.rutland@....com> > CC: Ian Campbell <ijc+devicetree@...lion.org.uk> > CC: Kumar Gala <galak@...eaurora.org> > CC: Randy Dunlap <rdunlap@...radead.org> > CC: Grant Likely <grant.likely@...aro.org> > > > Changelog: > > V2 > - Split the designware pcie enhancement patch to multiple > patches based on functionality added > - Remove the quirk code and add a patch to fix mps/mrss > tuning for ARM. Use kernel command line parameter > pci=pcie_bus_perf to work with Keystone PCI Controller. > Following patch addressed this. > [PATCH v1] ARM: pci: add call to pcie_bus_configure_settings() > - Add documentation for device tree bindings > - Add separate interrupt controller nodes for MSI and Legacy > IRQs and use irq map for legacy IRQ > - Use compatibility to identify v3.65 version of the DW hardware > and use it to customize the designware common code. > - Use reg property for configuration space instead of range > - Other minor updates based on code inspection. > > V1 > - Add an interrupt controller node for Legacy irq chip and use > interrupt map/map-mask property to map legacy IRQs A/B/C/D > - Add a Phy driver to replace the original serdes driver > - Move common application register handling code to a separate > file to allow re-use across other platforms that use older > DW PCIe h/w > - PCI quirk for maximum read request size. Check and override only > if the maximum is higher than what controller can handle. > - Converted to a module platform driver. > > > Murali Karicheri (8): > PCI: designware: add rd[wr]_other_conf API > PCI: designware: refactor host init code to re-use on v3.65 DW pci hw > PCI: designware: update pcie core driver to work with dw hw version > 3.65 > PCI: designware: add msi controller functions for v3.65 hw > PCI: designware: add PCI controller functions for v3.65 DW hw > phy: Add serdes phy driver for keystone > PCI: keystone: add pcie driver based on designware core driver > ARM: keystone: add pcie related options > > .../devicetree/bindings/pci/designware-pcie.txt | 42 ++ > .../devicetree/bindings/pci/pci-keystone.txt | 56 +++ > .../bindings/phy/phy-keystone-serdes.txt | 25 ++ > arch/arm/mach-keystone/Kconfig | 1 + > drivers/pci/host/Kconfig | 12 + > drivers/pci/host/Makefile | 2 + > drivers/pci/host/pci-dw-v3_65-msi.c | 149 +++++++ > drivers/pci/host/pci-dw-v3_65.c | 390 ++++++++++++++++++ > drivers/pci/host/pci-dw-v3_65.h | 34 ++ > drivers/pci/host/pci-keystone.c | 418 ++++++++++++++++++++ > drivers/pci/host/pcie-designware.c | 175 +++++--- > drivers/pci/host/pcie-designware.h | 42 +- > drivers/phy/Kconfig | 6 + > drivers/phy/Makefile | 1 + > drivers/phy/phy-keystone-serdes.c | 230 +++++++++++ > 15 files changed, 1531 insertions(+), 52 deletions(-) > create mode 100644 Documentation/devicetree/bindings/pci/pci-keystone.txt > create mode 100644 Documentation/devicetree/bindings/phy/phy-keystone-serdes.txt > create mode 100644 drivers/pci/host/pci-dw-v3_65-msi.c > create mode 100644 drivers/pci/host/pci-dw-v3_65.c > create mode 100644 drivers/pci/host/pci-dw-v3_65.h > create mode 100644 drivers/pci/host/pci-keystone.c > create mode 100644 drivers/phy/phy-keystone-serdes.c I'm not willing to merge phy-keystone-serdes.c because I don't maintain drivers/phy and because of the binary blob of register values it contains, but maybe somebody else will. I assume it could be merged by itself before the rest of this. I'm looking for acks from Mohit and/or Jingoo for the pci/host changes, and from Arnd for the devicetree/bindings changes. Adding these "-dw-3_64" files is sort of ugly. If that code is only used by keystone, maybe it could just be moved to pci-keystone.c? But I'll defer to Mohit and Jingoo on that and the way you modify pcie-designware.c. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists