linux-kernel - Re: [PATCH] staging: crystalhd: Do not mix integers and user pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Jun 2014 14:34:26 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Lubomir Rintel <lkundrak@...sk>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: crystalhd: Do not mix integers and user pointers

On Fri, Jun 20, 2014 at 01:16:17PM +0200, Lubomir Rintel wrote:
> Fixes the following sparse warnings:
> 
>   crystalhd/crystalhd_lnx.c:227:61: warning: incorrect type in argument 3 (different base types)
>   crystalhd/crystalhd_lnx.c:227:61:    expected unsigned long [unsigned] ua
>   crystalhd/crystalhd_lnx.c:227:61:    got void [noderef] <asn:1>*ua
>   crystalhd/crystalhd_lnx.c:229:65: warning: incorrect type in argument 4 (different base types)
>   crystalhd/crystalhd_lnx.c:229:65:    expected unsigned long [unsigned] ua
>   crystalhd/crystalhd_lnx.c:229:65:    got void [noderef] <asn:1>*ua
> 
> Done for the Eudyptula challenge.
> 

This patch is nice and fixes a bunch of warnings.

Normally, I would might you to redo it and remove the no longer needed
casts for ua_off as well...

	crystalhd_user_data((void __user *)ua_off, io->add_cdata,
                            ^^^^^^^^^^^^^^^
But we are going to delete this entire driver soon.  We may as well
apply yours as is and then delete it or just delete the driver without
applying this cleanup.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/