linux-kernel - Re: [for-next][PATCH] tracing: Add __field_struct macro for TRACE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 21 Jun 2014 14:07:23 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tony Luck <tony.luck@...il.com>
Subject: Re: [for-next][PATCH] tracing: Add __field_struct macro for
 TRACE_EVENT()

On Sat, Jun 21, 2014 at 07:50:25AM -0400, Steven Rostedt wrote:
> 
> Updates to the RAS tracepoints found that the __field() macro has a bug
> in it where you can not use it with structures. It only works with
> primitives. This is because of an added check to determine if the field
> is signed or not.
> 
> A new macro is created called __field_struct() that can be used to save
> structured data directly in the tracepoint and not have to settle for
> storing as an array with memcpy.
> 
> -- Steve
> 
> 
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
> for-next
> 
> Head SHA1: 4d4c9cc839a308be3289a361ccba4447ee140552
> 
> 
> Steven Rostedt (1):
>       tracing: Add __field_struct macro for TRACE_EVENT()
> 
> ----
>  include/trace/ftrace.h                     | 33 ++++++++++++++++++++++++++++++
>  samples/trace_events/trace-events-sample.h |  3 ++-
>  2 files changed, 35 insertions(+), 1 deletion(-)
> ---------------------------
> commit 4d4c9cc839a308be3289a361ccba4447ee140552
> Author: Steven Rostedt <rostedt@...dmis.org>
> Date:   Tue Jun 17 08:59:16 2014 -0400
> 
>     tracing: Add __field_struct macro for TRACE_EVENT()
>     
>     Currently the __field() macro in TRACE_EVENT is only good for primitive
>     values, such as integers and pointers, but it fails on complex data types
>     such as structures or unions. This is because the __field() macro
>     determines if the variable is signed or not with the test of:
>     
>       (((type)(-1)) < (type)1)
>     
>     Unfortunately, that fails when type is a structure.
>     
>     Since trace events should support structures as fields a new macro
>     is created for such a case called __field_struct() which acts exactly
>     the same as __field() does but it does not do the signed type check
>     and just uses a constant false for that answer.
>     
>     Cc: Tony Luck <tony.luck@...il.com>
>     Signed-off-by: Steven Rostedt <rostedt@...dmis.org>

Acked-by: Borislav Petkov <bp@...e.de>

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/