linux-kernel - Re: [PATCH 2/2] drivers/net/usb/asix_devices.c: inline ax88772

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 21 Jun 2014 04:09:04 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Fabian Frederick <fabf@...net.be>, linux-kernel@...r.kernel.org
CC:	"David S. Miller" <davem@...emloft.net>,
	Emil Goode <emilgoode@...il.com>, linux-usb@...r.kernel.org
Subject: Re: [PATCH 2/2] drivers/net/usb/asix_devices.c: inline ax88772_unbind

Hello.

On 06/21/2014 12:40 AM, Fabian Frederick wrote:

> inline this one line function used in driver_info structure

> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Emil Goode <emilgoode@...il.com>
> Cc: linux-usb@...r.kernel.org
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>   drivers/net/usb/asix_devices.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
> index 8a7582b..a41926a 100644
> --- a/drivers/net/usb/asix_devices.c
> +++ b/drivers/net/usb/asix_devices.c
> @@ -497,7 +497,7 @@ static int ax88772_bind(struct usbnet *dev, struct usb_interface *intf)
>   	return 0;
>   }
>
> -static void ax88772_unbind(struct usbnet *dev, struct usb_interface *intf)
> +static inline void ax88772_unbind(struct usbnet *dev, struct usb_interface *intf)
>   {
>   	kfree(dev->driver_priv);
>   }

    gcc is perfectly capable of figuring that out. No need to use *inline* 
outside the *.h files.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/