linux-kernel - [PATCH] include/trace/syscall.h: Use HAVE_SYSCALL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 21 Jun 2014 10:32:37 +0800
From:	Chen Gang <gang.chen.5i5j@...il.com>
To:	mingo@...hat.com, rostedt@...dmis.org
CC:	linux-kernel@...r.kernel.org
Subject: [PATCH] include/trace/syscall.h: Use HAVE_SYSCALL_TRACEPOINTS instead
 of TRACEPOINTS

At present, most architectures can support TRACEPOINTS, but about 10/29
architectures support HAVE_SYSCALL_TRACEPOINTS.

TIF_SYSCALL_TRACEPOINT depends on HAVE_SYSCALL_TRACEPOINTS, not all
architectures which support TRACEPOINTS also must support
TIF_SYSCALL_TRACEPOINT.

So at present, need use HAVE_SYSCALL_TRACEPOINTS instead of TRACEPOINTS,
or can not pass compiling. The related error (allmodconfig under score):

    CC      init/main.o
  In file included from include/asm-generic/preempt.h:4:0,
                   from arch/score/include/generated/asm/preempt.h:1,
                   from include/linux/preempt.h:18,
                   from include/linux/spinlock.h:50,
                   from include/linux/seqlock.h:35,
                   from include/linux/time.h:5,
                   from include/linux/stat.h:18,
                   from include/linux/module.h:10,
                   from init/main.c:15:
  include/trace/syscall.h: In function 'syscall_tracepoint_update':
  include/trace/syscall.h:39:23: error: 'TIF_SYSCALL_TRACEPOINT' undeclared (first use in this function)
    if (test_thread_flag(TIF_SYSCALL_TRACEPOINT))
                         ^
  include/linux/thread_info.h:103:45: note: in definition of macro 'test_thread_flag'
    test_ti_thread_flag(current_thread_info(), flag)
                                               ^
  include/trace/syscall.h:39:23: note: each undeclared identifier is reported only once for each function it appears in
    if (test_thread_flag(TIF_SYSCALL_TRACEPOINT))
                         ^
  include/linux/thread_info.h:103:45: note: in definition of macro 'test_thread_flag'
    test_ti_thread_flag(current_thread_info(), flag)
                                               ^
  make[1]: *** [init/main.o] Error 1
  make: *** [init] Error 2


Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com>
---
 include/trace/syscall.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/trace/syscall.h b/include/trace/syscall.h
index 291c282..a709cbd 100644
--- a/include/trace/syscall.h
+++ b/include/trace/syscall.h
@@ -33,7 +33,7 @@ struct syscall_metadata {
 	struct ftrace_event_call *exit_event;
 };
 
-#ifdef CONFIG_TRACEPOINTS
+#ifdef CONFIG_HAVE_SYSCALL_TRACEPOINTS
 static inline void syscall_tracepoint_update(struct task_struct *p)
 {
 	if (test_thread_flag(TIF_SYSCALL_TRACEPOINT))
-- 
1.9.2.459.g68773ac
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/