linux-kernel - RE: [patch 1/4] mm: vmscan: remove remains of kswapd-managed zone->all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Jun 2014 09:01:26 -0700
From:	Motohiro Kosaki <Motohiro.Kosaki@...fujitsu.com>
To:	Minchan Kim <minchan@...nel.org>,
	Johannes Weiner <hannes@...xchg.org>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Mel Gorman <mgorman@...e.de>, Rik van Riel <riel@...hat.com>,
	Michal Hocko <mhocko@...e.cz>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Motohiro Kosaki JP <kosaki.motohiro@...fujitsu.com>
Subject: RE: [patch 1/4] mm: vmscan: remove remains of kswapd-managed
 zone->all_unreclaimable



> -----Original Message-----
> From: Minchan Kim [mailto:minchan@...nel.org]
> Sent: Monday, June 23, 2014 2:16 AM
> To: Johannes Weiner
> Cc: Andrew Morton; Mel Gorman; Rik van Riel; Michal Hocko; linux-mm@...ck.org; linux-kernel@...r.kernel.org; Motohiro Kosaki JP
> Subject: Re: [patch 1/4] mm: vmscan: remove remains of kswapd-managed zone->all_unreclaimable
> 
> On Fri, Jun 20, 2014 at 12:33:47PM -0400, Johannes Weiner wrote:
> > shrink_zones() has a special branch to skip the all_unreclaimable()
> > check during hibernation, because a frozen kswapd can't mark a zone
> > unreclaimable.
> >
> > But ever since 6e543d5780e3 ("mm: vmscan: fix do_try_to_free_pages()
> > livelock"), determining a zone to be unreclaimable is done by directly
> > looking at its scan history and no longer relies on kswapd setting the
> > per-zone flag.
> >
> > Remove this branch and let shrink_zones() check the reclaimability of
> > the target zones regardless of hibernation state.
> >
> > Signed-off-by: Johannes Weiner <hannes@...xchg.org>
> Acked-by: Minchan Kim <minchan@...nel.org>
> 
> It would be not bad to Cced KOSAKI who was involved all_unreclaimable series several time with me.

Looks good to me.

KOSAKI Motohiro <Kosaki.motohiro@...fujitsu.com>